-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] Remove deprecated AppCacheStatus enum from the HTML5 package #15973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diemol
merged 4 commits into
SeleniumHQ:trunk
from
iampopovich:feat-10397/html5-helper-code-cleanup
Jul 5, 2025
Merged
[java] Remove deprecated AppCacheStatus enum from the HTML5 package #15973
diemol
merged 4 commits into
SeleniumHQ:trunk
from
iampopovich:feat-10397/html5-helper-code-cleanup
Jul 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
diemol
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @iampopovich!
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
partially fixes #10397
💥 What does this PR do?
This pull request removes the
AppCacheStatusenum from the Selenium codebase. The enum was deprecated and represented the application cache status, which is no longer relevant due to the deprecation of the AppCache API in modern browsers.Code removal:
java/src/org/openqa/selenium/html5/AppCacheStatus.java: Deleted theAppCacheStatusenum, including its values (UNCACHED,IDLE,CHECKING,DOWNLOADING,UPDATE_READY,OBSOLETE), associated methods (value,getEnum), and annotations (@Deprecated,@NullMarked). This change reflects the removal of outdated functionality tied to the deprecated AppCache API.🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Other
Description
Remove deprecated
AppCacheStatusenum from HTML5 packageRemove deprecated app cache commands from
DriverCommandinterfaceClean up obsolete AppCache API functionality
Changes diagram
Changes walkthrough 📝
AppCacheStatus.java
Delete entire AppCacheStatus enum filejava/src/org/openqa/selenium/html5/AppCacheStatus.java
AppCacheStatusenumvalue()andgetEnum()DriverCommand.java
Remove app cache command constantsjava/src/org/openqa/selenium/remote/DriverCommand.java
GET_APP_CACHEconstantCLEAR_APP_CACHEconstant